session, executor: add memTracker for DeleteExec #14289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/enhancement
XuHuaiyu
force-pushed
the
memtracker_for_delete
branch
from
706befa to
9fa2f04
Compare
|
/run-all-tests |
|
/run-all-tests |
tiancaiamao
reviewed
Dec 31, 2019
| if err != nil { | ||
| } | ||
| memUsageOfTxnState := txnState.Size() | ||
| err = t.RemoveRecord(ctx, h, data) |
There was a problem hiding this comment.
This is only one line change, is it easier to estimate the size of data?
There was a problem hiding this comment.
Using the existing interface is easier?
|
LGTM |
lysu
added
status/LGT2
XuHuaiyu
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/run-unit-test |
tiancaiamao
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before this PR, the memory usage of DeleteExec is not traced.
What is changed and how it works?
Add a memTracker for DeleteExec, to trace the memory usage of chk created during execution, and the memory usage of StmtBuffer and TxnBuffer.
Check List
Tests
Code changes
Side effects
N/A
Related changes
N/A
Release note
N/A