Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/cascades: add transformation rule MergeAdjacentLimit #14306

Merged
merged 14 commits into from
Jan 9, 2020
Merged

planner/cascades: add transformation rule MergeAdjacentLimit #14306

merged 14 commits into from
Jan 9, 2020

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 1, 2020

What problem does this PR solve?

This PR adds Transformation rule MergeAdjacentLimit which is a part of limit in cascades planner(#13709).

What is changed and how it works?

add a transformation rule MergeAdjacentLimit. The rule merge the limit and offset of adjacent limit to create a new GroupExpr with no simplification

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

@SeaRise SeaRise requested a review from a team as a code owner January 1, 2020 10:45
@ghost ghost requested review from eurekaka and francis0407 January 1, 2020 10:45
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Jan 1, 2020
@ghost ghost removed their request for review January 1, 2020 10:45
@claassistantio
Copy link

claassistantio commented Jan 1, 2020

CLA assistant check
All committers have signed the CLA.

@francis0407 francis0407 added the sig/planner SIG: Planner label Jan 2, 2020
planner/cascades/transformation_rules.go Show resolved Hide resolved
planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
planner/cascades/transformation_rules.go Outdated Show resolved Hide resolved
@SeaRise SeaRise requested a review from francis0407 January 9, 2020 06:06
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7988e54 into pingcap:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants