expression: open CAST string as real push down switcher #14323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
|
/run-integration-copr-test tikv=pr/6390 |
ghost
requested review from
qw4990,
XuHuaiyu,
eurekaka and
francis0407
and removed request for
a team
|
/run-integration-copr-test tikv=pr/6390 |
Signed-off-by: Lonng <heng@lonng.org>
|
/run-integration-copr-test tikv=pr/6390 |
|
/run-all-tests tikv=pr/6390 |
lonng
changed the title
XuHuaiyu
reviewed
Jan 3, 2020
| if isNull || err != nil { | ||
| return 0, isNull, err | ||
| a, isLHSNull, err := s.args[0].EvalReal(s.ctx, row) | ||
| if err != nil { |
There was a problem hiding this comment.
All of the expressions which have two arguments in TiDB have this pattern, they have inconsistent behavior with MySQL.
create table t (a varchar(10));
insert into t values ('2007');
select * from t where NULL + pow(7020, a);
The above statement should report an error.
|
Note: this PR should be merged with tikv/tikv#6390 together. |
|
/run-all-tests tikv=pr/6390 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
This PR opens the push-down switcher of the CAST string as real.
Additional, this PR fixes the #14326.
What is changed and how it works?
The tikv/tikv#6390 has fix the inconsistent with TiDB.
Check List
Tests