-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: fix parse date inconsistent with MySQL #14405
Conversation
Signed-off-by: Lonng <heng@lonng.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-3.0 failed |
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @lonng PTAL. |
/run-cherry-picker |
cherry pick to release-3.0 in PR #16242 |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The parse string to date inconsistent with MySQL:
The MySQL will check the hms even if the target type is
Date
.Mirror PR: tikv/tikv#6442
What is changed and how it works?
Check Date via
checkDatetimeType
Check List
Tests