-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: fix potential panic in GC worker (#14403) #14439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: store/tikv/gcworker/gc_worker.go store/tikv/gcworker/gc_worker_test.go
jackysp
added
type/3.0 cherry-pick
type/bugfix
This PR fixes a bug.
component/GC
labels
Jan 10, 2020
zz-jason
reviewed
Jan 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bb7133
added
status/LGT2
Indicates that a PR has LGTM 2.
status/can-merge
Indicates a PR has been approved by a committer.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jan 15, 2020
/run-all-tests |
@jackysp merge failed. |
/merge |
/run-all-tests |
@jackysp merge failed. |
/merge |
/run-all-tests |
@jackysp merge failed. |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/GC
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts:
store/tikv/gcworker/gc_worker.go
store/tikv/gcworker/gc_worker_test.go
What problem does this PR solve?
Cherry-pick #14403 to release 3.0.