Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix panic when init stats for cm sketch (#14421) #14470

Merged
merged 4 commits into from
Jan 19, 2020

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jan 14, 2020

Cherry pick #14421
Conflicts: cmsketch.go, handle.go

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx alivxxx changed the title tats: fix panic when init stats for cm sketch (#14421) stats: fix panic when init stats for cm sketch (#14421) Jan 14, 2020
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 14, 2020

/run-all-tests

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 15, 2020
@eurekaka
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

@lamxTyler merge failed.

@eurekaka
Copy link
Contributor

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Jan 16, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

Your auto merge job has been accepted, waiting for 14491

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

@lamxTyler merge failed.

@bb7133
Copy link
Member

bb7133 commented Jan 17, 2020

/run-unit-test

2 similar comments
@alivxxx
Copy link
Contributor Author

alivxxx commented Jan 17, 2020

/run-unit-test

@alivxxx
Copy link
Contributor Author

alivxxx commented Jan 17, 2020

/run-unit-test

@zz-jason zz-jason merged commit 2ddeb25 into pingcap:release-3.0 Jan 19, 2020
@alivxxx alivxxx deleted the stats-init branch January 19, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants