util: wrong memory count when use Tracker.ReplaceChild() #14513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @wshwsh12 , please update the release note. Thanks! |
qw4990
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #14533 |
sre-bot
added a commit
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When we use
Tracker.ReplaceChild()to replace/remove child, is only updates the result for the parent, but not updates the nodes in the path of the tracker tree recursively.What is changed and how it works?
Use
t.Consume(bytes)to update the result.Check List
Tests
Code changes
Side effects
Related changes
Release note
Fix a potential memory count problem.