Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: change the default value of txn-total-size-limit, add comment about its conflict with binlog #14522

Merged
merged 7 commits into from
Jan 21, 2020

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Better default configuration

What is changed and how it works?

When the binlog is enabled, the txn-total-size-limit value should not be too large.

See also #14006

Check List

Tests

  • No code

@tiancaiamao
Copy link
Contributor Author

PTAL @coocood @bb7133

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

config/config.toml.example Outdated Show resolved Hide resolved
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added this to the v4.0.0-beta.1 milestone Jan 19, 2020
@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jan 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

@tiancaiamao merge failed.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 21, 2020
@zz-jason zz-jason merged commit 00ad0f6 into pingcap:master Jan 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 21, 2020

cherry pick to release-4.0 in PR #14560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants