Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix json_key not compatible with MySQL (#14556) #14561

Merged
merged 1 commit into from
Jan 21, 2020
Merged

expression: fix json_key not compatible with MySQL (#14556) #14561

merged 1 commit into from
Jan 21, 2020

Conversation

hawkingrei
Copy link
Member

What problem does this PR solve?

port json_key patch from master to release3.0

Check List

Tests

  • Unit test
  • Integration test

Release note

fix json_key not compatible with MySQL

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Jan 21, 2020
zz-jason
zz-jason reviewed Jan 21, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Jan 21, 2020
@zz-jason zz-jason changed the title release 3.0: port json_key patch from master to release3.0 expression: fix json_key not compatible with MySQL (#14556) Jan 21, 2020
@zz-jason zz-jason requested a review from jackysp January 21, 2020 09:05
ngaut
ngaut approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 21, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 21, 2020

@hawkingrei merge failed.

@zz-jason zz-jason merged commit d91a052 into pingcap:release-3.0 Jan 21, 2020
@hawkingrei hawkingrei deleted the fix_json_key_for_release_3.0 branch January 29, 2020 13:58
@bb7133 bb7133 added this to the v3.0.10 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@ngaut ngaut ngaut approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v3.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @sre-bot @ngaut @zz-jason @bb7133