-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: grant table level privilege should check table exist (#14540) #14611
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for 14610, 14614 |
/run-all-tests |
@tiancaiamao merge failed. |
|
/run-unit-test Maybe I find the reason why sometimes |
@tiancaiamao How about filing an issue to record this data race and fix it in another PR? |
/merge |
Your auto merge job has been accepted, waiting for 14569, 14635, 14592, 14377 |
/run-all-tests |
@tiancaiamao merge failed. |
/run-all-tests |
return err | ||
} | ||
err = infoschema.ErrTableNotExists.GenWithStackByArgs(dbName, e.Level.TableName) | ||
// Note the table name compare is case sensitive here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiancaiamao Hi, may i ask. The TiDB lower_case_table_names
is default 2. So in this, i think we need check case insensitive here? Some case in #34610
Cherry-pick #14540
Release note:
Fix a bug that the table's existence is not checked when granting privileges on this table to users