executor, util: improve concurrency of statement summary(#14490) #14627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djshow832
added
type/enhancement
|
/rebuild |
djshow832
force-pushed
the
cherry-pick_14490_3.0
branch
from
1db79ce to
43105cb
Compare
bb7133
added
status/can-merge
jackysp
approved these changes
Feb 5, 2020
|
/run-all-tests |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicting files:
util/stmtsummary/statement_summary.goWhat problem does this PR solve?
Improve the performance in point get.
In point_get of wide_table_200, QPS decreases from 59k to 49k (refer to issue #14432). Because there're too many kinds of summaries to fit in the cache, creating a new summary needs to lock the cache, so much time is spent on waiting for the lock.
Also, some time is spent on generating digest.
After this PR, QPS increases back to 57k.
What is changed and how it works?
Check List
Tests
Code changes
N/A
Side effects
Related changes
N/A
Release note