Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: do not escape html special values (#14518) #14637

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Feb 5, 2020

cherry-pick #14518 to release-3.0


What problem does this PR solve?

For

create table test (data JSON);
insert into test (data) values ('{"a":"&"}');
select * from test;

MySQL would have result {"a":"&"}, while tidb shows {"a": "\u0026"}.

What is changed and how it works?

Do not escape the special html values &, > and <.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • do not escape html special values in json

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 5, 2020

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 5, 2020

Your auto merge job has been accepted, waiting for 14634, 14582

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit f7f504b into pingcap:release-3.0 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/json status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants