bindinfo: fix panic when load invalid sqls #14645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When sqls in the bind_info table is not valid, it will panic in
Update
.What is changed and how it works?
It panics in
The invalid sql would cause error in
newBindMeta
, and themeta
is nil, so it cause panic in following lines. This PR does not fixes it by check err first because we need to update thelastUpdateTime
to avoid fail in nextUpdate
.Check List
Tests
Code changes
Side effects
Related changes
Release note