-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support show create sequence #14674
Conversation
/run-unit-test |
/build |
1 similar comment
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW
test> show create sequence tt
(1146, u"Table 'test.tt' doesn't exist") -- shoud be Sequence xxx doesn't exist ?
It behaviors like MariaDB... I think it's temporary ok here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the code almost LGTM.
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What problem does this PR solve?
Support
show create sequence
syntax.After this PR, It goes like as follows:
What is changed and how it works?
fetchShowCreateSequence
logic inshow.go
ast.ShowCreateSequence
case to theast.ShowCreateTable
case inplanbuilder.go
(in most case, sequence are treated as a table)show create sequence
test in sequence_test.goCheck List
Tests
Related changes
Release note
show create sequence
in TiDB.