Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, expression: fix varchar type column flags are not compatible with MySQL #14806

Closed
wants to merge 15 commits into from

Conversation

Rustin170506
Copy link
Member

Signed-off-by: Rustin-Liu rustin.liu@gmail.com

What problem does this PR solve?

solve #13992

What is changed and how it works?

Add flag for utf8.

Check List

Tests

  • Unit test

Code changes

None
Side effects

None

Related changes

None

Release note

None

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Feb 15, 2020
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member Author

Hi @zimulala , It seems that my code changes have a great impact on other binary flag logics.
Am I correct on this way? Do you have any suggestions for fix it?

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@zz-jason zz-jason changed the title ddl: fix varchar type column flags are not compatible with MySQL ddl, expression: fix varchar type column flags are not compatible with MySQL Mar 2, 2020
@zimulala zimulala added sig/sql-infra SIG: SQL Infra and removed component/DDL1 labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants