planner/cascades: add implementationRule for IndexLookUpJoin #14831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eurekaka and
lzmhhh123
and removed request for
a team
|
/run-unit-test |
48 tasks
francis0407
commented
Feb 24, 2020
| @@ -222,17 +222,24 @@ func (opt *Optimizer) fillGroupStats(g *memo.Group) (err error) { | |||
| if g.Prop.Stats != nil { | |||
| return nil | |||
| } | |||
| // 1. Recursively fill the stats of all the child groups. | |||
There was a problem hiding this comment.
This change blocks #14857.
Codecov Report
@@ Coverage Diff @@
## master #14831 +/- ##
================================================
- Coverage 80.7843% 80.1721% -0.6123%
================================================
Files 505 499 -6
Lines 136852 129787 -7065
================================================
- Hits 110555 104053 -6502
+ Misses 17821 17481 -340
+ Partials 8476 8253 -223 |
…dex_hash_join # Conflicts: # planner/cascades/testdata/integration_suite_in.json # planner/cascades/testdata/integration_suite_out.json # planner/core/explain.go # planner/core/logical_plans.go
francis0407
added a commit
to francis0407/tidb
that referenced
this pull request
Apr 8, 2020
francis0407
added a commit
to francis0407/tidb
that referenced
this pull request
Apr 8, 2020
|
I'm going to close this PR since it hasn't been updated for a long time. feel free to reopen if you want to continue with it. thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR adds a new ImplemenationRule
ImplIndexJoinwhich will implementLogicalJoinasPhysicalIndexJoin,PhysicalIndexMergeJoinandPhysicalIndexHashJoin. (Although this PR only supportsPhysicalIndexJoin).What is changed and how it works?
This PR almost copies all of the codes from
planner/core/exhaust_physical_plans.go/LogicalJoin.tryToGetIndexJoin, but makes some little changes according to the cascades framework.For the convenience of the reviewers, this PR only supports build
PhysicalIndexJoinwhich inner child is aTableReader. In other words, I haven't implementedPhysicalIndexMergeJoin,PhysicalIndexHashJoinand IndexJoins which inner child is anIndexReader. (But this PR still changes about 500 lines T.T ).Check List
Tests
Code changes
Side effects