-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: adapter the generic hint struct TableOptimizerHint #14835
Conversation
Signed-off-by: Lonng <heng@lonng.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Lonng <heng@lonng.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@lonng merge failed. |
/rebuild |
/run-unit-test |
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The pingcap/parser#747 introduces a new field
HintData
into the structTableOptimizerHint
, which is used to save the extra hint information. The former implementation will cause field count growth as we adding more hint typesWhat is changed and how it works?
Check List
Tests
Release note