Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: adapter the generic hint struct TableOptimizerHint #14835

Merged
merged 3 commits into from
Feb 18, 2020
Merged

planner: adapter the generic hint struct TableOptimizerHint #14835

merged 3 commits into from
Feb 18, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Feb 18, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

The pingcap/parser#747 introduces a new field HintData into the struct TableOptimizerHint, which is used to save the extra hint information. The former implementation will cause field count growth as we adding more hint types

What is changed and how it works?

  1. Update the deps.
  2. Fix the compiler errors.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No need.

@lonng lonng requested a review from a team as a code owner February 18, 2020 11:03
@ghost ghost requested review from eurekaka and winoros and removed request for a team February 18, 2020 11:03
@lonng lonng added the sig/planner SIG: Planner label Feb 18, 2020
@lonng lonng added this to the v4.0.0-beta.1 milestone Feb 18, 2020
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
Signed-off-by: Lonng <heng@lonng.org>
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor Author

lonng commented Feb 18, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2020

@lonng merge failed.

@lonng
Copy link
Contributor Author

lonng commented Feb 18, 2020

/rebuild

@lonng
Copy link
Contributor Author

lonng commented Feb 18, 2020

/run-unit-test

@lonng lonng merged commit 1c09740 into pingcap:master Feb 18, 2020
@lonng lonng deleted the time-range branch February 18, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants