-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix compatibility of DBIsVisible #14862
Conversation
c.Assert(err, IsNil) | ||
isVisible = p.DBIsVisible("testvisdb6", "%", "visdb") | ||
c.Assert(isVisible, IsTrue) | ||
mustExec(c, se, "TRUNCATE TABLE mysql.user") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added tests can pass in the master too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
LGTM |
Ping @crazycs520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry pick to release-3.0 in PR #14939 |
What problem does this PR solve?
User with
trigger/references/execute
global privileges can not see all database names and use them, but in MySQL is okay.in TiDB:
in MySQL:
What is changed and how it works?
add
TriggerPriv
,EcecutePriv
,ReferencePriv
intoglobalDBVisible
Check List
Tests
Code changes
Side effects
Related changes
Release note