server: fix connection reset caused by alias length overflow #14870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
added 3 commits
February 24, 2020 18:56
imtbkcat
force-pushed
the
columnLimit
branch
from
7a4c5e7 to
74281ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #14870 +/- ##
================================================
+ Coverage 80.2213% 80.3066% +0.0853%
================================================
Files 503 503
Lines 130853 131100 +247
================================================
+ Hits 104972 105282 +310
+ Misses 17573 17532 -41
+ Partials 8308 8286 -22 |
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14769 |
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Feb 25, 2020
sre-bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Clients using binary protocol like PDO of PHP or JDBC, may occur error when query with very long alias, just like
select (a very long if else expression) from t;This is because the maxium size of column alias in mysql protocol is 256, but TiDB will return the long alias directly, MySQL will cut it until its less than 256 bytes.
https://dev.mysql.com/doc/refman/8.0/en/identifier-length.html
What is changed and how it works?
cut the name dump to 256 bytes.
Check List
Tests
Code changes
Side effects
Related changes
Release note