-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add test case for retrying union statement #15051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackysp
reviewed
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
djshow832
added
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
and removed
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
labels
Mar 2, 2020
djshow832
force-pushed
the
txn_retry_memory_leak
branch
from
March 3, 2020 10:24
dc86a80
to
19ba7cd
Compare
djshow832
force-pushed
the
txn_retry_memory_leak
branch
from
March 4, 2020 02:52
19ba7cd
to
8bb0f62
Compare
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15051 +/- ##
==============================================
- Coverage 80.3% 80.2849% -0.0151%
==============================================
Files 502 502
Lines 131980 131940 -40
==============================================
- Hits 105980 105928 -52
- Misses 17618 17625 +7
- Partials 8382 8387 +5 |
AilinKid
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 4, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add test case for #15050.
What is changed and how it works?
Just add some test cases to test retrying
UNION
andSHOW
statements.Check List
Tests
I did the same as #15050 and the log shows
UNION
statement is not retried.Code changes
N/A
Side effects
N/A
Related changes
N/A
Release note ( This release note applies to the parser PR pingcap/parser#755)
UNION
statement.