Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Migrate dataForIndexes from package infoschema to exector #15116

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

gauss1314
Copy link
Contributor

UCP #15024

What problem does this PR solve?

Migrate dataForIndexes from package infoschema to exector.

Check List

Tests

  • Unit test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 4, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@zz-jason zz-jason added sig/execution SIG execution contribution This PR is from a community contributor. labels Mar 4, 2020
Signed-off-by: gauss <gauss1314@gmail.com>
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #15116 into master will decrease coverage by 0.0298%.
The diff coverage is 87.931%.

@@               Coverage Diff                @@
##             master     #15116        +/-   ##
================================================
- Coverage   80.3224%   80.2925%   -0.0299%     
================================================
  Files           503        502         -1     
  Lines        132384     131940       -444     
================================================
- Hits         106334     105938       -396     
+ Misses        17681      17618        -63     
- Partials       8369       8384        +15

@gauss1314
Copy link
Contributor Author

@lonng @crazycs520 PTAL

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauss1314 gauss1314 changed the title executor: Migrate dataForIndexes from package infoschema to exector UCP: executor: Migrate dataForIndexes from package infoschema to exector Mar 4, 2020
@gauss1314 gauss1314 changed the title UCP: executor: Migrate dataForIndexes from package infoschema to exector executor: Migrate dataForIndexes from package infoschema to exector Mar 4, 2020
@lonng lonng requested review from reafans and crazycs520 March 5, 2020 02:04
Copy link
Contributor

@reafans reafans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reafans reafans added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Mar 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit debe5cb into pingcap:master Mar 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 5, 2020

Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL

@sre-bot
Copy link
Contributor

sre-bot commented Mar 5, 2020

Team gauss1314 complete task #15024 and get 50 score, currerent score 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants