Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: support check the "CommanName" of tls-cert for status-port(http/grpc) (#15137) #15165

Closed
wants to merge 5 commits into from
Closed

server: support check the "CommanName" of tls-cert for status-port(http/grpc) (#15137) #15165

wants to merge 5 commits into from

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 5, 2020

cherry-pick #15137 to release-3.1

What problem does this PR solve?

add CN check for TiDB's http/grpc API

What is changed and how it works?

  • add configuration
  • config check hook in http/grpc server
  • add test

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
remove https://github.com/pingcap/tidb/compare/master...lysu:check_CN_between_tidbs?expand=1#diff-209d74aa1a4826e6cf6e0b29455087c7R221
and install self-signed CA to operation-system

Code changes

  • n/a

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release 3.0

Release note

  • Write release note for bug-fix or new feature.

This change is Reviewable

@lysu @sre-bot
cherry pick pingcap#15137 to release-3.1
8ec3c75 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 5, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Mar 5, 2020
Merged
@sre-bot sre-bot added security Everything related with security status/all-tests-passed labels Mar 5, 2020
@sre-bot sre-bot requested review from gregwebs, imtbkcat and jackysp March 5, 2020 15:54
gregwebs
gregwebs previously approved these changes Mar 5, 2020
View reviewed changes
jackysp
jackysp previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp dismissed their stale review March 6, 2020 02:26

test failed

@lysu
Copy link
Contributor

lysu commented Mar 6, 2020

/run-all-tests

jackysp
jackysp approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 6, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 6, 2020

Your auto merge job has been accepted, waiting for 14968

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 6, 2020

@sre-bot merge failed.

@lysu
Copy link
Contributor

lysu commented Mar 9, 2020

/run-unit-test

@lysu lysu requested a review from jackysp March 9, 2020 08:48
imtbkcat
imtbkcat approved these changes Mar 9, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Mar 17, 2020

cherry-picked with #15414

@lysu lysu closed this Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtbkcat imtbkcat imtbkcat approved these changes

@gregwebs gregwebs gregwebs left review comments

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/config security Everything related with security status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @lysu @jackysp @gregwebs @imtbkcat