Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Migrate dataForStatistics, dataForTikVRegionPeers, dataForTiDBHotRegions from package infoschema to executor #15202

Merged
merged 18 commits into from
Mar 11, 2020

Conversation

gauss1314
Copy link
Contributor

UCP #15025
UCP #15030
UCP #15032

What problem does this PR solve?

Migrate dataForStatistics, dataForTikVRegionPeers, dataForTiDBHotRegions from package infoschema to executor.

Check List

Tests

  • Unit test

…iDBHotRegions from package to

Signed-off-by: gauss <gauss1314@gmail.com>
@gauss1314 gauss1314 requested a review from a team as a code owner March 7, 2020 15:50
@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 7, 2020
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team March 7, 2020 15:50
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #15202 into master will increase coverage by 0.023%.
The diff coverage is 43.4782%.

@@               Coverage Diff               @@
##             master     #15202       +/-   ##
===============================================
+ Coverage   80.3363%   80.3593%   +0.023%     
===============================================
  Files           503        503               
  Lines        132839     132903       +64     
===============================================
+ Hits         106718     106800       +82     
+ Misses        17716      17706       -10     
+ Partials       8405       8397        -8

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 8, 2020
@reafans
Copy link
Contributor

reafans commented Mar 9, 2020

/run-unit-test

@gauss1314
Copy link
Contributor Author

@lonng @crazycs520 PTAL ,CI fails due to problems with random functions.

@lonng
Copy link
Contributor

lonng commented Mar 10, 2020

/award-point 150

@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

Update score success, the task will rewarded 150 after merged.

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@lonng
Copy link
Contributor

lonng commented Mar 10, 2020

@gauss1314 Take it easy, the CI failure is not caused by your PR, and we are fixing the unstable test cases.

@gauss1314
Copy link
Contributor Author

@lonng @crazycs520 ping~

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Mar 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3e16e1f into pingcap:master Mar 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

Team gauss1314 complete task #15025 and get 50 score, currerent score 200

@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

Congratulations, you get 200 score from easy level tasks in challenge program season-2, and if your PRs in reviewed stage all got merged, the score will be 200, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

@gauss1314 gauss1314 deleted the migrateDataForStatistics branch March 11, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants