Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix decimal of function FROM_UNIXTIME (#14936) #15270

Merged
merged 4 commits into from
Mar 12, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 10, 2020

cherry-pick #14936 to release-3.0


What problem does this PR solve?

Fix #14935

What is changed and how it works?

Check List

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 10, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SunRunAway UT failed?

@SunRunAway SunRunAway added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2020
@SunRunAway
Copy link
Contributor

@SunRunAway UT failed?

Fixed.

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 12, 2020

Your auto merge job has been accepted, waiting for 15339

@SunRunAway SunRunAway removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/PTAL labels Mar 12, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 12, 2020

/run-all-tests

@sre-bot sre-bot merged commit bf82a71 into pingcap:release-3.0 Mar 12, 2020
@SunRunAway SunRunAway added this to the v3.0.12 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants