Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: stop the server when writing binlog failed (#15324) #15339

Merged
merged 3 commits into from
Mar 12, 2020
Merged

server: stop the server when writing binlog failed (#15324) #15339

merged 3 commits into from
Mar 12, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Mar 12, 2020 •
edited
Loading

Conflicts:
server/server.go

What problem does this PR solve?

Cherry-pick #15324 to release 3.0.

Release note

Write release note for bug-fix or new feature.
Stop the server when writing binlog failed.

@jackysp jackysp requested review from shenli, coocood and zimulala March 12, 2020 09:41
@jackysp jackysp added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 12, 2020
lysu
lysu reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT1 Indicates that a PR has LGTM 1. type/3.0-cherry-pick labels Mar 12, 2020
@zimulala zimulala added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2020
zimulala
zimulala approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 12, 2020

@jackysp merge failed.

@zimulala
Copy link
Contributor

/run-all-tests

@zimulala zimulala merged commit 8c4696b into pingcap:release-3.0 Mar 12, 2020
jackysp added a commit to jackysp/tidb that referenced this pull request Mar 12, 2020
@jackysp
server: stop the server when writing binlog failed (pingcap#15324) (p…
5a4cde0 
…ingcap#15339)
@jackysp jackysp deleted the exit_on_critical_3.0 branch November 25, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@zimulala zimulala zimulala approved these changes

@shenli shenli Awaiting requested review from shenli

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @sre-bot @zimulala @lysu