Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support hint USE_CASCADES(true|false) to use/disuse cascades planner in a single query #15352

Merged
merged 8 commits into from
Mar 16, 2020

Conversation

gauss1314
Copy link
Contributor

@gauss1314 gauss1314 commented Mar 13, 2020

UCP #15215

What problem does this PR solve?

Close #15215. Add support hint USE_CASCADES(true|false) to use/disuse cascades planner in a single query.

What is changed and how it works?

Handle USE_CASCADES hint.

Check List

Tests

  • Unit test

… planner in a single query

Signed-off-by: gauss <gauss1314@gmail.com>
@gauss1314 gauss1314 requested a review from a team as a code owner March 13, 2020 04:44
@sre-bot
Copy link
Contributor

sre-bot commented Mar 13, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 300 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 13, 2020
@ghost ghost requested review from eurekaka and lzmhhh123 and removed request for a team March 13, 2020 04:44
planner/optimize.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #15352 into master will decrease coverage by 0.0003%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #15352        +/-   ##
================================================
- Coverage   80.3906%   80.3903%   -0.0004%     
================================================
  Files           502        502                
  Lines        133411     133485        +74     
================================================
+ Hits         107250     107309        +59     
- Misses        17732      17744        +12     
- Partials       8429       8432         +3

@gauss1314 gauss1314 changed the title planner: [WIP]support hint USE_CASCADES(true|false) to use/disuse cascades planner in a single query planner: support hint USE_CASCADES(true|false) to use/disuse cascades planner in a single query Mar 16, 2020
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!
LGTM

@francis0407 francis0407 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2020
@gauss1314 gauss1314 requested a review from zz-jason March 16, 2020 04:44
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

@gauss1314 merge failed.

@lzmhhh123 lzmhhh123 removed their request for review March 16, 2020 09:42
@francis0407
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit af861ee into pingcap:master Mar 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

Team gauss1314 complete task #15215 and get 300 score, currerent score 500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCP: support hint 'USE_CASCADES(ON|OFF)' to use/disuse cascades planner in a single query
4 participants