ddl: add missing ErrorCount++ when update Error #15373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhiqiangxu thanks for your contributing, could you add a test case in this PR? |
It seems there's no test for |
|
@zhiqiangxu zhiqiangxu#1 PTAL |
add test case for pingcap#15373
wow, that's cool ! |
|
Here are some problem with run test cases parallel, I will take a look. |
|
/run-all-tests |
Deardrops
reviewed
Mar 19, 2020
There was a problem hiding this comment.
LGTM, could you add some PR descriptions? Refer to TiDB's PR template
zimulala
added
status/LGT2
AilinKid
reviewed
Mar 19, 2020
AilinKid
added
status/LGT3
AilinKid
approved these changes
Mar 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #15373 +/- ##
===========================================
Coverage 80.4152% 80.4152%
===========================================
Files 502 502
Lines 134028 134028
===========================================
Hits 107779 107779
Misses 17801 17801
Partials 8448 8448 |
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a missing bit of code.