-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: insert negative primary key into auto_random table won't trigger rebase #15397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
March 16, 2020 05:36
bb7133
reviewed
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
AilinKid
reviewed
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,nice job
Sorry for being absent in this review for such a long time, my fault.
AilinKid
approved these changes
Apr 15, 2020
zz-jason
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 15, 2020
/run-all-tests |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jun 12, 2020
bb7133
pushed a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For now, inserting a negative number into auto_random table will trigger rebase:
The hex representation of
1510612738
is5A0A1F02
. A lot of auto ids are consumed.It is more intuitive not to rebase in this case.
What is changed and how it works?
Only rebase auto_random id when the inserted number is positive.
Check List
Tests
Code changes
Side effects
Related changes
Release note