Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support recover truncate table #15398

Merged
merged 3 commits into from
Mar 18, 2020
Merged

ddl: support recover truncate table #15398

merged 3 commits into from
Mar 18, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Make recover table support truncate table.
This is use for cherry-pick to 3.0

eg:

>insert into t values (1,1)
>truncate table t;
>rename table t to t_new;
>recover table t;
>select * from t;
+---+---+
| a | b |
+---+---+
| 1 | 1 |
+---+---+

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • No

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Support recover truncated table.

@crazycs520 crazycs520 added the sig/sql-infra SIG: SQL Infra label Mar 16, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner March 16, 2020 06:20
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team March 16, 2020 06:20
@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #15398 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15398   +/-   ##
===========================================
  Coverage   80.3909%   80.3909%           
===========================================
  Files           502        502           
  Lines        133831     133831           
===========================================
  Hits         107588     107588           
  Misses        17804      17804           
  Partials       8439       8439

XuHuaiyu
XuHuaiyu reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the sig/execution SIG execution label Mar 16, 2020
zimulala
zimulala reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 18, 2020
AilinKid
AilinKid approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

executor/executor_test.go Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/run-all-tests

@AilinKid AilinKid added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 18, 2020
@crazycs520 crazycs520 merged commit 783c2de into pingcap:master Mar 18, 2020
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Mar 18, 2020
@crazycs520
ddl: support recover truncate table (pingcap#15398)
8edd7ff
@crazycs520 crazycs520 mentioned this pull request Mar 18, 2020
Merged
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Mar 18, 2020
@crazycs520
ddl: support recover truncate table (pingcap#15398)
6fa2ab3
@crazycs520 crazycs520 mentioned this pull request Mar 18, 2020
Merged
bb7133 pushed a commit that referenced this pull request Mar 19, 2020
@crazycs520
ddl: support recover truncate table (#15398) (#15458)
796e623
sre-bot pushed a commit that referenced this pull request Mar 19, 2020
@crazycs520
ddl: support recover truncate table (#15398) (#15460)
c745300
@you06 you06 added this to the v4.0.0-rc milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@zimulala zimulala zimulala left review comments

@AilinKid AilinKid AilinKid approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
v4.0.0-rc
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @zimulala @XuHuaiyu @AilinKid @you06