privilege: add DDL and DML privilege check for system tables (#15095) #15417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
compatibility-breaker
sre-bot
requested review from
AilinKid,
crazycs520,
Deardrops,
lonng,
tangenta and
zimulala
|
/rebuild |
|
/run-all-tests |
|
/run-unit-test |
tangenta
added
status/all-tests-passed
status/LGT2
|
/run-cherry-picker |
sre-bot
added a commit
to sre-bot/tidb
that referenced
this pull request
Mar 18, 2020
|
cherry pick to release-3.1 in PR #15445 |
bb7133
pushed a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15095 to release-3.0
Conflicting files:
tables.go
privileges.go
privileges_test.go
What problem does this PR solve?
Add DDL and DML privilege check for system tables in performance_schema and metrics_schema.
What is changed and how it works?
Prevent users from executing
ALTER,DROP,INDEX,INSERT,UPDATE,DELETEstatements on predefined tables.Privileges of those tables which are defined in these schema by users themselves are kept untouched.
Check List
Tests
Code changes
Side effects
Related changes
N/A
Release note