-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use https protocol between tidb-pd tidb-tidb when cluster-ssl configured (#15342) (#15419) #15430
Merged
sre-bot
merged 2 commits into
pingcap:release-3.1
from
sre-bot:release-3.1-0043698378fe
Mar 18, 2020
Merged
*: use https protocol between tidb-pd tidb-tidb when cluster-ssl configured (#15342) (#15419) #15430
sre-bot
merged 2 commits into
pingcap:release-3.1
from
sre-bot:release-3.1-0043698378fe
Mar 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
sig/sql-infra
SIG: SQL Infra
sig/execution
SIG execution
component/server
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
security
Everything related with security
status/all-tests-passed
type/3.0-cherry-pick
type/3.1-cherry-pick
labels
Mar 17, 2020
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 17, 2020
/run-all-tests |
jackysp
removed
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 18, 2020
jackysp
reviewed
Mar 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imtbkcat
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 18, 2020
Your auto merge job has been accepted, waiting for 15442 |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
security
Everything related with security
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
type/3.1-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15419 to release-3.1
cherry-pick #15342 to release-3.0
What problem does this PR solve?
fixes #15120
PD or TiDB RESTful service will require https when cluster configured with cluster-ssl-*, but tidb-server only can send http request.
What is changed and how it works?
change to https client when "cluster-ssl-*" configured
Check List
Tests
configure pd/tidb/tikv as https://pingcap.com/docs/stable/how-to/secure/enable-tls-between-components/
then try to use TiDB http-api or "cluster table"
Code changes
Side effects
Related changes
Need to cherry-pick to the release branch
Release note
use https request between tidb-pd tidb-tidb when cluster-ssl configured.
This change is