Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use https protocol between tidb-pd tidb-tidb when cluster-ssl configured (#15342) (#15419) #15430

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 17, 2020

cherry-pick #15419 to release-3.1


cherry-pick #15342 to release-3.0


What problem does this PR solve?

fixes #15120

PD or TiDB RESTful service will require https when cluster configured with cluster-ssl-*, but tidb-server only can send http request.

What is changed and how it works?

change to https client when "cluster-ssl-*" configured

Check List

Tests

  • Manual test

configure pd/tidb/tikv as https://pingcap.com/docs/stable/how-to/secure/enable-tls-between-components/

then try to use TiDB http-api or "cluster table"

Code changes

  • replace all http to http/https
  • use https client when "cluster-ssl-*" configured

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release branch
    Release note

  • use https request between tidb-pd tidb-tidb when cluster-ssl configured.


This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution component/server priority/release-blocker This issue blocks a release. Please solve it ASAP. security Everything related with security status/all-tests-passed type/3.0-cherry-pick type/3.1-cherry-pick labels Mar 17, 2020
@sre-bot sre-bot requested review from imtbkcat and jackysp March 17, 2020 12:51
@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 17, 2020

/run-all-tests

@jackysp jackysp removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 18, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 18, 2020

Your auto merge job has been accepted, waiting for 15442

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 18, 2020

/run-all-tests

@sre-bot sre-bot merged commit ccb8583 into pingcap:release-3.1 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server priority/release-blocker This issue blocks a release. Please solve it ASAP. security Everything related with security sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants