-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix select current_role() error #15534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
This PR fixes a bug.
component/privilege
needs-cherry-pick-3.0
labels
Mar 20, 2020
ghost
requested review from
SunRunAway and
wshwsh12
and removed request for
a team
March 20, 2020 13:24
jackysp
reviewed
Mar 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
tiancaiamao
approved these changes
Mar 23, 2020
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Mar 23, 2020
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15534 +/- ##
================================================
+ Coverage 80.3979% 80.4278% +0.0299%
================================================
Files 502 502
Lines 134149 134206 +57
================================================
+ Hits 107853 107939 +86
+ Misses 17822 17806 -16
+ Partials 8474 8461 -13 |
/run-all-tests |
cherry pick to release-3.0 in PR #15569 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 23, 2020
cherry pick to release-3.1 in PR #15570 |
sre-bot
added a commit
that referenced
this pull request
Mar 23, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For user with no role, execute
SET ROLE ALL
, thenSELECT CURRENT_ROLE()
Problem Summary:
This was caused by
GetAllRole
, which will returnnil
if user has no role.What is changed and how it works?
let
GetAllRole
return a empty slice, rather thannil
.Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Side effects
Release note