Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix select current_role() error #15534

Merged
merged 3 commits into from
Mar 23, 2020

Conversation

imtbkcat
Copy link

What problem does this PR solve?

For user with no role, execute SET ROLE ALL, then SELECT CURRENT_ROLE()

mysql> set role all;
Query OK, 0 rows affected (0.00 sec)

mysql> select current_role();
ERROR 1105 (HY000): Missing session variable when eval builtin

Problem Summary:
This was caused by GetAllRole, which will return nil if user has no role.

What is changed and how it works?

let GetAllRole return a empty slice, rather than nil.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

@imtbkcat imtbkcat requested review from tiancaiamao and jackysp March 20, 2020 13:24
@imtbkcat imtbkcat requested a review from a team as a code owner March 20, 2020 13:24
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team March 20, 2020 13:24
@github-actions github-actions bot added the sig/execution SIG execution label Mar 20, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 23, 2020
@tiancaiamao
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #15534 into master will increase coverage by 0.0299%.
The diff coverage is 86.9863%.

@@               Coverage Diff                @@
##             master     #15534        +/-   ##
================================================
+ Coverage   80.3979%   80.4278%   +0.0299%     
================================================
  Files           502        502                
  Lines        134149     134206        +57     
================================================
+ Hits         107853     107939        +86     
+ Misses        17822      17806        -16     
+ Partials       8474       8461        -13     

@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit d60567f into pingcap:master Mar 23, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 23, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

cherry pick to release-3.0 in PR #15569

@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

cherry pick to release-3.1 in PR #15570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants