-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsql: check the killed flag in the distsql package (#15592) #15615
Merged
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-00dc69c6a7f1
Mar 28, 2020
Merged
distsql: check the killed flag in the distsql package (#15592) #15615
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-00dc69c6a7f1
Mar 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
component/server
status/all-tests-passed
type/3.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
Mar 24, 2020
/run-all-tests |
jackysp
reviewed
Mar 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SunRunAway
reviewed
Mar 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SunRunAway
approved these changes
Mar 28, 2020
SunRunAway
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Mar 28, 2020
/run-all-tests |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15592 to release-3.0
What problem does this PR solve?
Problem Summary:
Fix an issue from the forum https://asktug.com/t/tidb-new-feature-max-execution-time/309
There is no index in this query and TiKV scans the whole table.
max_excution_time doesn't work because the
killed
flag is checked in eachNext
function,the code doesn't run to
Next
until it read sufficient rows in a chunk.What is changed and how it works?
Check the
killed
flag in the distsql package level, so the query could break after reading each region result. The code looks like that:https://github.com/pingcap/tidb/compare/master...tiancaiamao:coprocessor-kill?expand=1#diff-7492d01b7aac81533194642850a45b8eR206
Related changes
#14552
#12852
Check List
Tests
Release note
Improve
max-execution-time
usability by checking the interrupt signal when a new region data is read.