executor: check unequal handles when buildTableReader4INLJoin #15675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
qw4990
reviewed
Mar 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #15675 +/- ##
================================================
+ Coverage 80.4243% 80.4643% +0.0399%
================================================
Files 504 504
Lines 134473 135086 +613
================================================
+ Hits 108149 108696 +547
- Misses 17833 17921 +88
+ Partials 8491 8469 -22 |
zz-jason
approved these changes
Mar 26, 2020
zz-jason
added
status/can-merge
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15734 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15735 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 26, 2020
|
cherry pick to release-4.0 in PR #15736 |
sre-bot
added a commit
that referenced
this pull request
Mar 31, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15658
Problem Summary:
Before this commit, buildTableReaderForIndexJoin assumes that there is only one value for handles in lookupContent. Thus we'll fetch redundant rows.
What is changed and how it works?
Proposal: xxx
What's Changed:
Check whether there are redundant unequal
handlevalues in buildTableReaderForIndexJoin.How it Works:
Related changes
Check List
Tests
Side effects
Release note