Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong result of Not/IsTrue/IsFalse functions (#10498) #15916

Merged
merged 4 commits into from
Apr 1, 2020
Merged

expression: fix wrong result of Not/IsTrue/IsFalse functions (#10498) #15916

merged 4 commits into from
Apr 1, 2020

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 31, 2020 •
edited
Loading

cherry-pick #10498

TiPB change: pingcap/tipb#174
TiKV change: tikv/tikv#7314
They should be merged at the same time.

@eurekaka eurekaka mentioned this pull request Mar 31, 2020
Merged
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 1, 2020

/run-unit-test

3 similar comments
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 1, 2020

/run-unit-test

@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 1, 2020

/run-unit-test

@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 1, 2020

/run-unit-test

@eurekaka eurekaka requested review from qw4990 and SunRunAway April 1, 2020 08:07
SunRunAway
SunRunAway reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2020
qw4990
qw4990 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2020
@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2020

Your auto merge job has been accepted, waiting for 15915

@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit 1bf5c8d into pingcap:release-3.0 Apr 1, 2020
@eurekaka eurekaka deleted the pick_not_30 branch April 1, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @sre-bot @SunRunAway @qw4990