Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix partition selection on hash partitioned table (#16070) #16076

Merged
merged 6 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 4, 2020

cherry-pick #16070 to release-3.1


What problem does this PR solve?

See the test case.

What is changed and how it works?

Remove redundancy code and get back the missing code

https://github.com/pingcap/tidb/compare/release-3.0...tiancaiamao:partition-selection-on-hash?expand=1#diff-0411f48b4045359c9f116ef6a779c3efR736-R740

This bug exists on branch 3.0, the master branch is fine.

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 4, 2020

/run-all-tests

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

/rebuild

@tiancaiamao
Copy link
Contributor

/run-common-test

@tiancaiamao
Copy link
Contributor

/run-common-test tidb-test=pr/1036

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1036

@tiancaiamao tiancaiamao reopened this Apr 13, 2020
@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1036

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1036

2 similar comments
@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1036

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=pr/1036

@tiancaiamao
Copy link
Contributor

PTAL @imtbkcat @zimulala @jackysp

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 15, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16377, 16378, 16277

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

@sre-bot merge failed.

@jackysp
Copy link
Member

jackysp commented Apr 15, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 15866, 16382, 16379, 16376

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit cedba7f into pingcap:release-3.1 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants