Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, sessionctx : Add 'last_plan_from_cache' to help know whether sql's plan is from plan cache #16321

Merged
merged 67 commits into from
Apr 17, 2020
Merged

planner, sessionctx : Add 'last_plan_from_cache' to help know whether sql's plan is from plan cache #16321

merged 67 commits into from
Apr 17, 2020

Conversation

danmay319
Copy link
Contributor

@danmay319 danmay319 commented Apr 13, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #16127

Problem Summary:

What is changed and how it works?

What's Changed:

  • add a session scope system variable last_plan_from_cache to help decide whether the plan cache got hit.

How it Works:

  • last_plan_from_cache` indicates whether the last executed statement hit the plan cache. (true for yes, false for no)

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

The default value of last_plan_from_cache is false. Set operations of last_plan_from_cache will be ignored, and a warning will be given about that.

danmay319 and others added 27 commits March 23, 2020 02:53
@danmay319
handle sql hint: enable_plan_cache
cfc73cb
@danmay319
add one sql hint to tidb: enable_plan_cache(bool)
acbe322
@danmay319
Add hint test, change enable_plan_cache(bool) to ignore_plan_cache()
3d5673e
@danmay319
Update prepared_test.go
d3d201e 
change mystmt to stmt
@danmay319
update warning message
0b831f0
@danmay319 @zz-jason
Update executor/prepared.go
a461181 
Co-Authored-By: Zhang Jian <zjsariel@gmail.com>
@danmay319
remove hints warning check, adjust code to improve overall performance
0fab6b3
@danmay319
adjust annotation
251cc8d
@danmay319
change mystmt
c48cff7
@danmay319
move hint handler to cacheable_checker.go, add some test for cacheabl…
5ded580 
…e_checker.go
@danmay319
restore the code deleted by commit cfc73cb
3646bbc
@zz-jason
Merge branch 'master' into master
1735a74
@danmay319
restore the code added by commit cfc73cb
671483d
@danmay319
Use HintIgnorePlanCache instead of ignore_plan_cache
f9b3b04
@danmay319
Merge branch 'master' into master
429d817
@danmay319
Merge branch 'master' into master
0bde7a2
@danmay319
Merge remote-tracking branch 'tidb/master'
d6b968f
@danmay319
Add some annotations for TestGlobalAndSessionBindingBothExist.
a092efb 
Improve the testing process.
@danmay319
change the hint for global binding
d6f16c0
@danmay319
refine the annotations.
fa66b99
@sre-bot
Merge branch 'master' into master
7171233
@zz-jason
Merge branch 'master' into master
fc9bde3
@zz-jason
Merge branch 'master' into master
26948eb
@danmay319
Merge remote-tracking branch 'tidb/master'
f3f1d0a
@danmay319
Merge remote-tracking branch 'origin/master'
2ca43d3
@danmay319
add plan cache global variables
ed3358f
@danmay319
remove dup ref
6eade39
@danmay319 danmay319 requested a review from a team as a code owner April 13, 2020 09:13
@danmay319 danmay319 self-assigned this Apr 13, 2020
@ghost ghost requested a review from francis0407 April 13, 2020 09:13
eurekaka
eurekaka reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

Can we change the variable name to a simpler one, e.g, last_plan_from_cache?

@danmay319
Copy link
Contributor Author

Can we change the variable name to a simpler one, e.g, last_plan_from_cache?

I also think the name of this variable is too long, renamed now.

@danmay319 danmay319 changed the title planner, sessionctx : Add 'last_statement_found_in_plan_cache' to help know whether sql's plan is from plan cache planner, sessionctx : Add 'last_plan_from_cache' to help know whether sql's plan is from plan cache Apr 17, 2020
@danmay319 danmay319 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 17, 2020
francis0407
francis0407 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407 francis0407 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit ff7413f into pingcap:master Apr 17, 2020
@danmay319 danmay319 mentioned this pull request Apr 20, 2020
Merged
@danmay319
Copy link
Contributor Author

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 26, 2020
@danmay319 @sre-bot
cherry pick pingcap#16321 to release-4.0
f656e43 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Apr 26, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2020

cherry pick to release-4.0 in PR #16830

@sre-bot sre-bot mentioned this pull request Apr 26, 2020
Merged
zz-jason pushed a commit that referenced this pull request Apr 30, 2020
@sre-bot
planner, sessionctx : Add 'last_plan_from_cache' to... (#16321) (#16830)
db0310b
@danmay319 danmay319 mentioned this pull request May 11, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request May 11, 2020
Merged
5 tasks
@Reminiscent Reminiscent mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@francis0407 francis0407 francis0407 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees

@danmay319 danmay319

Labels
component/session sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

we should add extra info to inform that a query plan is from plan cache
5 participants
@danmay319 @eurekaka @sre-bot @zz-jason @francis0407