Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix double negation error when PushDownNot (#16094) #16423

Merged
merged 3 commits into from
Apr 16, 2020
Merged

expression: fix double negation error when PushDownNot (#16094) #16423

merged 3 commits into from
Apr 16, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 15, 2020

cherry-pick #16094 to release-3.1

What problem does this PR solve?

Issue Number: close #15725

Problem Summary:

not not col should not be optimized to a

What is changed and how it works?

Do not eliminate the innermost NOT in PushDownNot.

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

N/A

Release note

@XuHuaiyu @sre-bot
cherry pick pingcap#16094 to release-3.1
fd90e2f 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 15, 2020
Merged
eurekaka
eurekaka reviewed Apr 15, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuHuaiyu please resolve conflicts.

@XuHuaiyu
Copy link
Contributor

blocked by #16424

@XuHuaiyu XuHuaiyu requested a review from eurekaka April 15, 2020 14:12
@XuHuaiyu
Copy link
Contributor

PTAL @eurekaka @winoros

eurekaka
eurekaka reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu
Copy link
Contributor

/run-integration-common-test
/run-sqllogic-test

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2020
winoros
winoros approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason merged commit bbc3206 into pingcap:release-3.1 Apr 16, 2020
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@winoros winoros winoros approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@XuHuaiyu XuHuaiyu

Labels
component/expression sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @XuHuaiyu @eurekaka @winoros @zz-jason