ddl: fix sequence default value will cause primary-key occur not-null error #16437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16437 +/- ##
===========================================
Coverage 80.6005% 80.6005%
===========================================
Files 506 506
Lines 137633 137633
===========================================
Hits 110933 110933
Misses 18119 18119
Partials 8581 8581 |
zimulala
reviewed
Apr 16, 2020
|
/run-unit-test |
zimulala
added
the
status/can-merge
|
/run-all-tests |
AilinKid
added
status/LGT2
|
@AilinKid merge failed. |
|
/run-integration-copr-test |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-unit-test |
|
/run-unit-test |
|
cherry pick to release-4.0 in PR #16510 |
|
/build |
sre-bot
added a commit
that referenced
this pull request
Apr 17, 2020
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Apr 18, 2020
lysu
pushed a commit
that referenced
this pull request
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close bug competition issue #11
What is changed and how it works?
if the default is expr(sequence expr), return nil directly in function
checkDefaultValueotherwise will cause some primary key check problem.
Check List
Tests
Release note: ddl: fix sequence default value will cause primary-key occur not-null error