session: fix unseccessfully isolation read engines init session (#16465) #16482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/session
type/3.1-cherry-pick
type/bugfix
SunRunAway
reviewed
Apr 16, 2020
zz-jason
reviewed
Apr 22, 2020
There was a problem hiding this comment.
@lzmhhh123 please fix CI:
[2020-04-17T08:20:29.741Z] main_test.go:43:
[2020-04-17T08:20:29.741Z] c.Assert(variable.SysVars[variable.TiDBIsolationReadEngines].Value, Equals, "tikv, tiflash, tidb")
[2020-04-17T08:20:29.741Z] ... obtained string = "tikv, tiflash"
[2020-04-17T08:20:29.741Z] ... expected string = "tikv, tiflash, tidb"
zz-jason
added
the
priority/release-blocker
|
/run-all-tests |
lzmhhh123
force-pushed
the
release-3.1-39cc8935cdc9
branch
from
3261848 to
0f03107
Compare
|
/run-all-tests |
|
/run-all-tests |
SunRunAway
added
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16465 to release-3.1
What problem does this PR solve?
Problem Summary: as the title says.
What is changed and how it works?
What's Changed: isolation read engines should be re-init after config load.
Related changes
Check List
Tests
Side effects