executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables (#16456) #16502

sre-bot · 2020-04-17T02:32:39Z

cherry-pick #16456 to release-4.0

What problem does this PR solve?

Problem Summary:
Add sum_errors and sum_warnings to statements_summary.
These 2 fields indicate the total errors and warnings encountered for each kind of SQL.

What is changed and how it works?

What's Changed:
ONLY summarize runtime errors now. It's a big move to also consider compiler errors, so it's not suitable for 4.0.
MySQL: Statements that has parser errors are not summarized in statement summary tables.
TiDB: Statements that has parser errors or compiler errors are not summarized.

How it Works:
Error: check whether it succeeded.
Warning: get StmtCtx.WarningCount().

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test

Side effects

N/A

Release note

Add two fields sum_errors and sum_warnings to statement summary tables.

…ent summary tables (pingcap#16456)

sre-bot · 2020-04-17T02:32:41Z

/run-all-tests

AilinKid

LGTM

zimulala

LGTM

sre-bot · 2020-04-17T02:39:15Z

/run-all-tests

sre-bot · 2020-04-17T02:41:19Z

@sre-bot merge failed.

djshow832 · 2020-04-17T02:44:58Z

/rebuild

djshow832 · 2020-04-17T09:38:31Z

/rebuild

djshow832 · 2020-04-17T09:49:23Z

/run-all-tests

bb7133 · 2020-04-17T10:16:53Z

Failed CI:

[2020-04-17T10:05:41.429Z] --- FAIL: TestInfo (2.75s)
[2020-04-17T10:05:41.429Z]     leaktest.go:143: Test TestInfo check-count 50 appears to have leaked: github.com/pingcap/tidb/domain.(*Domain).loadSchemaInLoop(0xc001718c60, 0x2faf080)
[2020-04-17T10:05:41.429Z]          /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:494 +0x269                                                                      [2020-04-17T10:05:41.429Z]         created by github.com/pingcap/tidb/domain.(*Domain).Init
[2020-04-17T10:05:41.429Z]          /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:721 +0x5d8
[2020-04-17T10:05:41.429Z] FAIL

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/32912/pipeline/85

bb7133 · 2020-04-17T10:17:00Z

/run-unit-test

bb7133 · 2020-04-17T10:28:09Z

Failed CI case:

[2020-04-17T10:22:58.545Z] ----------------------------------------------------------------------
[2020-04-17T10:22:58.545Z] FAIL: db_change_test.go:532: testStateChangeSuite.TestWriteOnly
[2020-04-17T10:22:58.545Z]                                                                                                                                                                                            [2020-04-17T10:22:58.545Z] db_change_test.go:538:
[2020-04-17T10:22:58.545Z]     s.runTestInSchemaState(c, model.StateWriteOnly, true, addColumnSQL, sqls, nil)
[2020-04-17T10:22:58.545Z] db_change_test.go:623:
[2020-04-17T10:22:58.545Z]     c.Assert(errors.ErrorStack(checkErr), Equals, "")
[2020-04-17T10:22:58.545Z] ... obtained string = "" +
[2020-04-17T10:22:58.545Z] ...     "[domain:8028]Information schema is changed during the execution of the statement(for example, table definition may be updated by other DDL ran in parallel). If you see this error often, try increasing `tidb_max_delta_schema_count`. [try again later]\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/errors.AddStack\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20190809092503-95897b64e011/errors.go:174\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/errors.Trace\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20190809092503-95897b64e011/juju_adaptor.go:15\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/tidb/store/tikv.(*twoPhaseCommitter).checkSchemaValid\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/32927/pipeline

bb7133 · 2020-04-17T10:28:17Z

Failed CI case:

[2020-04-17T10:22:58.545Z] ----------------------------------------------------------------------
[2020-04-17T10:22:58.545Z] FAIL: db_change_test.go:532: testStateChangeSuite.TestWriteOnly
[2020-04-17T10:22:58.545Z]                                                                                                                                                                                            [2020-04-17T10:22:58.545Z] db_change_test.go:538:
[2020-04-17T10:22:58.545Z]     s.runTestInSchemaState(c, model.StateWriteOnly, true, addColumnSQL, sqls, nil)
[2020-04-17T10:22:58.545Z] db_change_test.go:623:
[2020-04-17T10:22:58.545Z]     c.Assert(errors.ErrorStack(checkErr), Equals, "")
[2020-04-17T10:22:58.545Z] ... obtained string = "" +
[2020-04-17T10:22:58.545Z] ...     "[domain:8028]Information schema is changed during the execution of the statement(for example, table definition may be updated by other DDL ran in parallel). If you see this error often, try increasing `tidb_max_delta_schema_count`. [try again later]\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/errors.AddStack\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20190809092503-95897b64e011/errors.go:174\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/errors.Trace\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20190809092503-95897b64e011/juju_adaptor.go:15\n" +
[2020-04-17T10:22:58.545Z] ...     "github.com/pingcap/tidb/store/tikv.(*twoPhaseCommitter).checkSchemaValid\n" +
[2020-04-17T10:22:58.545Z] ...     "\t/home/jenkins/agent

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/32927/pipeline

bb7133 · 2020-04-17T10:28:26Z

/run-unit-test

zz-jason

LGTM

qw4990

LGTM

executor, infoschema, util: add sum_errors and sum_warnings to statem…

ade61f2

…ent summary tables (pingcap#16456)

sre-bot requested a review from a team as a code owner April 17, 2020 02:32

sre-bot mentioned this pull request Apr 17, 2020

executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables #16456

Merged

sre-bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution component/infoschema type/4.0-cherry-pick labels Apr 17, 2020

ghost requested a review from XuHuaiyu April 17, 2020 02:32

sre-bot requested review from AilinKid, crazycs520, Deardrops, SunRunAway and zimulala April 17, 2020 02:32

sre-bot assigned djshow832 Apr 17, 2020

AilinKid reviewed Apr 17, 2020

View reviewed changes

zimulala approved these changes Apr 17, 2020

View reviewed changes

zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2020

djshow832 added the status/all-tests-passed label Apr 17, 2020

Merge branch 'release-4.0' into release-4.0-1f24b9e03b70

c2cf3c6

Merge branch 'release-4.0' into release-4.0-1f24b9e03b70

702c544

zz-jason approved these changes Apr 17, 2020

View reviewed changes

qw4990 approved these changes Apr 17, 2020

View reviewed changes

zz-jason removed request for SunRunAway, XuHuaiyu, Deardrops and crazycs520 April 17, 2020 10:31

zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 17, 2020

bb7133 merged commit cb208cd into pingcap:release-4.0 Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables (#16456) #16502

executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables (#16456) #16502

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

AilinKid left a comment

zimulala left a comment

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

djshow832 commented Apr 17, 2020

djshow832 commented Apr 17, 2020

djshow832 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

zz-jason left a comment

qw4990 left a comment

executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables (#16456) #16502

executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables (#16456) #16502

Conversation

sre-bot commented Apr 17, 2020

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

sre-bot commented Apr 17, 2020

AilinKid left a comment

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

djshow832 commented Apr 17, 2020

djshow832 commented Apr 17, 2020

djshow832 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

bb7133 commented Apr 17, 2020

zz-jason left a comment

Choose a reason for hiding this comment

qw4990 left a comment

Choose a reason for hiding this comment