-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: support partition pruning for partition expression floor(unix_timestamp()) (#16402) #16521
Merged
jackysp
merged 4 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-d8e6cf8de69b
Apr 20, 2020
Merged
planner/core: support partition pruning for partition expression floor(unix_timestamp()) (#16402) #16521
jackysp
merged 4 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-d8e6cf8de69b
Apr 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
status/PTAL
type/3.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
Apr 17, 2020
/run-all-tests |
imtbkcat
reviewed
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jackysp
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
type/enhancement
The issue or PR belongs to an enhancement.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16402 to release-3.0
What problem does this PR solve?
Issue Number: close #16354
Problem Summary:
Support partition pruning for
floor(unix_timestamp()
What is changed and how it works?
What's Changed:
Take function
floor(unix_timestamp())
as monotoneIncFuncs, special handle for this case.How it Works:
If the partition function is monotoneous, i.e.
That partition function can be used by the partition pruning algorithm.
If we view
floor(unix_timestamp())
as a single function, it basicly conform to the definition.Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Release note