Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: support partition pruning for partition expression floor(unix_timestamp()) (#16402) #16523

Merged
merged 5 commits into from
Apr 22, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020

cherry-pick #16402 to release-4.0


What problem does this PR solve?

Issue Number: close #16354

Problem Summary:

Support partition pruning for floor(unix_timestamp()

create table t (ts timestamp(3)) partition by range (floor(unix_timestamp(ts))) (
...)

What is changed and how it works?

What's Changed:

Take function floor(unix_timestamp()) as monotoneIncFuncs, special handle for this case.

How it Works:

If the partition function is monotoneous, i.e.

for all x > y => f(x) > f(y)

That partition function can be used by the partition pruning algorithm.

If we view floor(unix_timestamp()) as a single function, it basicly conform to the definition.

for all x > y => f(x) >= f(y)

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner April 17, 2020 08:22
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 19, 2020

@lysu, @jackysp, @eurekaka, @winoros, @XuHuaiyu, @imtbkcat, PTAL.

@imtbkcat
Copy link

@tiancaiamao please fix conflict

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

Done @imtbkcat @jackysp

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2020
@tiancaiamao
Copy link
Contributor

PTAL @jackysp

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 22, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot merge failed.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Apr 22, 2020
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

Your auto merge job has been accepted, waiting for:

  • 16699
  • 16540
  • 16567
  • 16703

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot merge failed.

@zz-jason
Copy link
Member

/run-sqllogic-test-2

1 similar comment
@zz-jason
Copy link
Member

/run-sqllogic-test-2

@zz-jason zz-jason merged commit 8523208 into pingcap:release-4.0 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants