-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: support partition pruning for partition expression floor(unix_timestamp()) (#16402) #16523
planner/core: support partition pruning for partition expression floor(unix_timestamp()) (#16402) #16523
Conversation
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
@tiancaiamao please fix conflict |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @jackysp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@sre-bot merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@sre-bot merge failed. |
/run-sqllogic-test-2 |
1 similar comment
/run-sqllogic-test-2 |
cherry-pick #16402 to release-4.0
What problem does this PR solve?
Issue Number: close #16354
Problem Summary:
Support partition pruning for
floor(unix_timestamp()
What is changed and how it works?
What's Changed:
Take function
floor(unix_timestamp())
as monotoneIncFuncs, special handle for this case.How it Works:
If the partition function is monotoneous, i.e.
That partition function can be used by the partition pruning algorithm.
If we view
floor(unix_timestamp())
as a single function, it basicly conform to the definition.Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Release note