Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix unit test and make test running serially. (#16525) #16615

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 20, 2020

cherry-pick #16525 to release-4.0


What problem does this PR solve?

Issue Number: close #16328

Problem Summary: UT fails. Root cause is running unit test parallelly (some prepare plan cache test.)

What is changed and how it works?

What's Changed: Run test serially.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested review from a team as code owners April 20, 2020 09:49
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 20, 2020

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 22, 2020
@zz-jason
Copy link
Member

/run-all-test

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

Your auto merge job has been accepted, waiting for:

  • 16689

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 22, 2020

@sre-bot merge failed.

@SunRunAway SunRunAway merged commit dd1c6ef into pingcap:release-4.0 Apr 22, 2020
@crazycs520 crazycs520 modified the milestones: v4.0.0-rc.2, v4.0.0-rc.1 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/test sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants