-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: resolve order by item from select fields first when checking FULL_GROUP_BY constraint (#16332) #16620
planner: resolve order by item from select fields first when checking FULL_GROUP_BY constraint (#16332) #16620
Conversation
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
f741da6
to
f19207d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/run-all-tests |
/run-mybatis-test |
cherry-pick #16332 to release-3.0
What problem does this PR solve?
Problem Summary:
MySQL does not report error for this query.
What is changed and how it works?
What's Changed:
Resolve ByItem of ORDER BY using select fields first, if the ByItem refers to the field, skip check for it since it has been checked already; if not, resolve it from input plan.
Related changes
Check List
Tests
Side effects
N/A
Release note
only_full_group_by
SQL mode is set