util: build right range when where stmt only have string column. #16645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
added
type/bugfix
ghost
requested review from
XuHuaiyu and
eurekaka
and removed request for
XuHuaiyu and
a team
|
/run-all-tests |
|
/run-integration-copr-test |
Codecov Report
@@ Coverage Diff @@
## master #16645 +/- ##
================================================
- Coverage 80.4000% 80.3720% -0.0280%
================================================
Files 506 506
Lines 137082 136861 -221
================================================
- Hits 110214 109998 -216
+ Misses 18268 18264 -4
+ Partials 8600 8599 -1 |
eurekaka
reviewed
Apr 21, 2020
util/ranger/checker.go
Outdated
| @@ -32,6 +32,11 @@ func (c *conditionChecker) check(condition expression.Expression) bool { | |||
| case *expression.ScalarFunction: | |||
| return c.checkScalarFunction(x) | |||
| case *expression.Column: | |||
| if s, ok := condition.(*expression.Column); ok { | |||
| if s.RetType.EvalType() == types.ETString { | |||
| return false | |||
There was a problem hiding this comment.
Then we cannot use index for this kind of filter? would it cause performance regression?
There was a problem hiding this comment.
Yes. Maybe it cause performance regression, but It is a correctness question. In Mysql, the range is empty also. If we use index, it can only filter null and ''.
eurekaka
added
the
status/can-merge
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 21, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16657 |
|
cherry pick to release-3.0 in PR #16658 |
|
cherry pick to release-3.1 in PR #16659 |
|
cherry pick to release-4.0 in PR #16660 |
sre-bot
added a commit
that referenced
this pull request
Apr 29, 2020
sre-bot
added a commit
that referenced
this pull request
May 7, 2020
bb7133
pushed a commit
that referenced
this pull request
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16505 , close #16190
Problem Summary: TableIndexScan's result is different from TableFullScan and Selection.
What is changed and how it works?
What's Changed: If the where stmt only have String column, it shouldn't be one of accessCondition to build access range. Because we should convert the string to float to check it is ture/false.
How it Works: However, revert #16135 that only cover some cases. The pr can cover all situations.
Related changes
Check List
Tests
Release note
Fix the wrong result when where stmt only have string column.