Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support auto_random table option (#16750) #16813

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 24, 2020

cherry-pick #16750 to release-4.0


What problem does this PR solve?

Problem Summary: support auto_random_base table option

What is changed and how it works?

How it Works:
After this table option:
We can do the auto_random rebase by alter table xxx auto_random_base = num
Also we can specify the initial auto_random base by create table t xxx(xxx) auto_random_base = num

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

support auto_random table option for rebase auto_random allocator

@sre-bot sre-bot requested a review from a team as a code owner April 24, 2020 15:17
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 24, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

don't worry, the releated parser hasn't been cherry-picked, wait for a while

@AilinKid
Copy link
Contributor

the linked parser is in pingcap/parser#831

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala previously approved these changes Apr 26, 2020
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

/run-all-tests

zz-jason
zz-jason previously approved these changes Apr 26, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 26, 2020
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

@sre-bot merge failed.

@AilinKid
Copy link
Contributor

pingcap/parser#831

@AilinKid AilinKid dismissed stale reviews from zz-jason and zimulala via 7edf0f3 April 27, 2020 08:07
@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-integration-copr-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-integration-copr-test

@AilinKid
Copy link
Contributor

/run-check_dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants