Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, types: copy enum/set instead of refer the underlying data #16858

Merged
merged 6 commits into from
Apr 28, 2020
Merged

executor, types: copy enum/set instead of refer the underlying data #16858

merged 6 commits into from
Apr 28, 2020

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Apr 27, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Issue Number: close #16854

Problem Summary:

What is changed and how it works?

What's Changed:
Copy enum/set instead of referring the underlying data in GetMysqlEnum and GetMysqlSet

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

  • Performance regression
    • Consumes more MEM

Release note

  • Fix unstable result when select distinct enum column or set column.

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution needs-cherry-pick-2.1 labels Apr 27, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner April 27, 2020 06:28
@ghost ghost requested review from SunRunAway and removed request for a team April 27, 2020 06:28
@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited
Loading

Codecov Report

Merging #16858 into master will increase coverage by 0.0137%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master     #16858        +/-   ##
================================================
+ Coverage   80.3238%   80.3375%   +0.0137%     
================================================
  Files           508        507         -1     
  Lines        138269     137394       -875     
================================================
- Hits         111063     110379       -684     
+ Misses        18515      18348       -167     
+ Partials       8691       8667        -24

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2020
zz-jason
zz-jason previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

Your auto merge job has been accepted, waiting for:

  • 16743

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

/run-all-tests

SunRunAway
SunRunAway suggested changes Apr 28, 2020
View reviewed changes
types/datum.go Outdated Show resolved Hide resolved
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

SunRunAway
SunRunAway approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

@XuHuaiyu merge failed.

@SunRunAway SunRunAway merged commit 26e208b into pingcap:master Apr 28, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 28, 2020
@XuHuaiyu @sre-bot
cherry pick pingcap#16858 to release-2.1
5e66940 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Apr 28, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

cherry pick to release-2.1 in PR #16889

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 28, 2020
@XuHuaiyu @sre-bot
executor, types: copy enum/set instead of refer the underlying data (p…
622ec0d 
…ingcap#16858)
@sre-bot sre-bot mentioned this pull request Apr 28, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

cherry pick to release-3.0 in PR #16890

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 28, 2020
@XuHuaiyu @sre-bot
executor, types: copy enum/set instead of refer the underlying data (p…
02206ab 
…ingcap#16858)
@sre-bot sre-bot mentioned this pull request Apr 28, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

cherry pick to release-3.1 in PR #16891

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 28, 2020
@XuHuaiyu @sre-bot
executor, types: copy enum/set instead of refer the underlying data (p…
ffb2c33 
…ingcap#16858)
@sre-bot sre-bot mentioned this pull request Apr 28, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

cherry pick to release-4.0 in PR #16892

zz-jason pushed a commit that referenced this pull request Apr 28, 2020
@sre-bot
executor, types: copy enum/set instead of refer the... (#16858) (#16892)
8ee5edd
sre-bot added a commit that referenced this pull request Apr 28, 2020
@sre-bot
executor, types: copy enum/set instead of refer the underlying data (#…
f59d933 
…16858) (#16891)
ngaut pushed a commit that referenced this pull request Apr 29, 2020
@sre-bot
executor, types: copy enum/set instead of refer the underlying data (#…
49de760 
…16858) (#16890)
ti-srebot added a commit that referenced this pull request Jun 18, 2020
@sre-bot @XuHuaiyu @ti-srebot
executor, types: copy enum/set instead of refer the underlying data (#…
47e286b 
…16858) (#16889)

* cherry pick #16858 to release-2.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflicts

* fix ci

Co-authored-by: HuaiyuXu <391585975@qq.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group by on enum column got wrong result
5 participants
@XuHuaiyu @tiancaiamao @sre-bot @SunRunAway @zz-jason