tikv: recheck kv status before invalidate region on sending fail (#16933) #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/config
component/tikv
type/4.0-cherry-pick
type/enhancement
tiancaiamao
reviewed
Apr 30, 2020
store/tikv/region_cache.go
Outdated
| @@ -1384,8 +1393,13 @@ func (s *Store) reResolve(c *RegionCache) { | |||
| addr = store.GetAddress() | |||
| if s.addr != addr { | |||
| state := resolved | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please address conflict @lysu
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-integration-copr-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16933 to release-4.0
What problem does this PR solve?
Problem Summary:
the simple and cherry-pickable part of #15989
do addition kv status check before invalidate region to avoid false-invalidate region cache when tikv isn't down but sending request failure(like meet network timeout).
What is changed and how it works?
Proposal: xxx
What's Changed:
do addition kv status check before invalidate region
How it Works:
do addition kv status check before invalidate region
and add metric to new check operation.
if status API unavaliable tidb will works as code before this pr
Related changes
Check List
Tests
Side effects
Release note
recheck kv status before invalidating region on sending fail
This change is