Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: allow TableDual to match the required property if the row count is 0 (#16927) #17014

Merged
merged 3 commits into from
May 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 7, 2020

cherry-pick #16927 to release-3.0


What problem does this PR solve?

Issue Number: close #16841

Problem Summary:

Before this PR, PhysicalTableDual cannot match any required property(and it will return an invalidTask in findBestTask if the property is not empty).
But the case in #16841 use a MergeJoin hint to enforce to use the merge join. While one child of the LogicalJoin is a LogicalTableDual, which cannot match the property. So the optimizer cannot find a physical plan for that SQL.

What is changed and how it works?

What's Changed:

This PR allow TableDual to match the required property if the row count is 0.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

  • Fix the scenario that the planner cannot find a physical plan when there is a TableDual.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@francis0407
Copy link
Member

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 7, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 7, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2020
@zz-jason zz-jason removed the request for review from winoros May 7, 2020 15:41
@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 19e5905 into pingcap:release-3.0 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants